Use enum for bidirectional mappings #1357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbintt
reviewed
Dec 4, 2023
robbintt
previously approved these changes
Dec 4, 2023
robbintt
previously approved these changes
Dec 4, 2023
robbintt
reviewed
Dec 4, 2023
gzpcho
changed the title
|
Holding off on merging until expanded unit test coverage PR is merged. |
gzpcho
added a commit
that referenced
this pull request
Dec 7, 2023
|
Can you use deploy-int test stage and verify the deploy agent works with some restart or new deployment on helloworld hosts? |
|
might be a good idea to use serverless here as well as we just want to test stage transition. |
gzpcho
changed the title
This reverts commit ab1fabe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use python3 preferred way to define and access bidirectional mappings.
Test Plan:
helloworlddummyservice-server-yaqin-test-0a03c4a2